Skip to content

Conversation

@rayokota
Copy link
Member

Please prefix all TypeScript pull-requests with [Typescript]

What

  • Add Accept-Version header
  • Minor fix to AWS driver to account for web identity token file
  • User newer subject-based DEK creation API
  • Properly handle Avro bytes type

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@rayokota rayokota requested review from a team as code owners October 30, 2025 20:56
Copilot AI review requested due to automatic review settings October 30, 2025 20:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the Accept-Version header to Schema Registry client requests and includes several important fixes: improved AWS KMS driver support for web identity token files, adoption of a newer subject-based DEK creation API with fallback to legacy endpoints, and proper handling of Avro bytes type serialization/deserialization.

Key Changes:

  • Added Accept-Version: 8.0 header to all Schema Registry REST API calls
  • Updated DEK creation to use newer subject-based API path with 405 fallback
  • Fixed Avro bytes type handling to bypass buffer conversion

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
schemaregistry/rest-service.ts Added Accept-Version header initialization
schemaregistry/rules/encryption/dekregistry/dekregistry-client.ts Refactored DEK creation to support subject-based API with legacy fallback
schemaregistry/rules/encryption/awskms/aws-driver.ts Added web identity token file check to credential provider logic
schemaregistry/serde/avro.ts Added special handling for bytes type in serialization/deserialization
schemaregistry/test/serde/avro.spec.ts Added test case for bytes type serialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants