[KIP-848] Tests for changes in DescribeConsumerGroups #1984
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
Tests for the DescribeConsumerGroups API have been updated to handle and verify the new ConsumerGroupType field for both classic and consumer protocols, and obsolete skip logic has been removed.
- Added
ConsumerGroupTypeimport and updatedconsume_messagesto accept agroup_protocolparameter. - Expanded
verify_describe_groupsto assertdesc.typefor both classic and consumer group protocols. - Removed the conditional skip for consumer protocol tests.
| 'on_commit': verify_commit_result, | ||
| 'auto.offset.reset': 'earliest'} | ||
|
|
||
| if group_protocol == 'classic' : |
There was a problem hiding this comment.
Remove the extra space before the colon in the if statement to follow style guidelines (e.g., PEP8).
| if group_protocol == 'classic' : | |
| if group_protocol == 'classic': |
| # Delete group | ||
| perform_admin_operation_sync(admin_client.delete_consumer_groups, [group], request_timeout=10) | ||
|
|
||
| consumer_group = 'test-group-consumer' |
There was a problem hiding this comment.
[nitpick] The test logic for classic and consumer group protocols is nearly identical; consider refactoring into a parameterized helper or loop to reduce duplication.
| # Delete group | ||
| perform_admin_operation_sync(admin_client.delete_consumer_groups, [group], request_timeout=10) | ||
|
|
||
| consumer_group = 'test-group-consumer' |
There was a problem hiding this comment.
There are trailing spaces at the end of this line; consider removing them to clean up formatting.
| consumer_group = 'test-group-consumer' | |
| consumer_group = 'test-group-consumer' |
airlock-confluentinc
bot
force-pushed
the
dev_test_describeGroup
branch
from
c7e0997 to
f370a0b
Compare
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
Modified test for changes in DescribeConsumerGroups api