- 
                Notifications
    You must be signed in to change notification settings 
- Fork 934
DGS-22734 Add Accept-Version header #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 🎉 All Contributor License Agreements have been signed. Ready to merge.  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements multiple improvements to the Confluent Kafka Python client including API updates, protocol enhancements, and bug fixes. The changes focus on adding versioning support, improving AWS KMS integration, enhancing DEK (Data Encryption Key) registry functionality, and fixing Avro serialization for bytes type.
- Add Accept-Version header with value "8.0" to all Schema Registry requests
- Update DEK registry to use subject-based API with fallback to legacy API
- Fix AWS KMS driver to properly handle web identity token authentication
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description | 
|---|---|
| src/confluent_kafka/schema_registry/_sync/schema_registry_client.py | Add Accept-Version header to HTTP requests | 
| src/confluent_kafka/schema_registry/_async/schema_registry_client.py | Add Accept-Version header to HTTP requests | 
| src/confluent_kafka/schema_registry/rules/encryption/dek_registry/dek_registry_client.py | Implement subject-based DEK creation API with fallback | 
| src/confluent_kafka/schema_registry/rules/encryption/awskms/aws_driver.py | Fix AWS web identity token handling | 
| src/confluent_kafka/schema_registry/_sync/avro.py | Fix Avro bytes type serialization/deserialization | 
| src/confluent_kafka/schema_registry/_async/avro.py | Fix Avro bytes type serialization/deserialization | 
| tests/schema_registry/_sync/test_avro_serdes.py | Add test for Avro bytes serialization | 
| tests/schema_registry/_async/test_avro_serdes.py | Add test for Avro bytes serialization | 
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
        
          
                src/confluent_kafka/schema_registry/rules/encryption/dek_registry/dek_registry_client.py
          
            Show resolved
            Hide resolved
        
      | 
 | 




What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups