fix(idempotency): make kafka-storage command return correct changed_when status#2383
Open
Sverre H. Huseby (sverrehu) wants to merge 154 commits intoconfluentinc:8.2.xfrom
Open
fix(idempotency): make kafka-storage command return correct changed_when status#2383Sverre H. Huseby (sverrehu) wants to merge 154 commits intoconfluentinc:8.2.xfrom
Sverre H. Huseby (sverrehu) wants to merge 154 commits intoconfluentinc:8.2.xfrom
Conversation
…24-04' (confluentinc#1956) Co-authored-by: service-bot-app[bot] <foo-bar+service-bot-app[bot]@users.noreply.github.com>
…24-04' (confluentinc#1960) Co-authored-by: service-bot-app[bot] <foo-bar+service-bot-app[bot]@users.noreply.github.com> Co-authored-by: service-bot-app[bot] <189278048+service-bot-app[bot]@users.noreply.github.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR sets
changed_whenfor thekafka-storage formatcommand based on the output from the command. This will avoid false positives when nothing is changed.PS: This is a reimplementation of #1895 for the current development branch. (You implemented part of my original PR in #2181)
Type of change
How Has This Been Tested?
Tested in our local provisioning pipeline.
Checklist:
For local testing of the
changed_whenlogic, you may use the playbook here: https://github.com/sverrehu/ansible-tests/tree/master/kafka-storage-formatYou will need to change the
binary_base_pathinplaybook.ymlto point to your Kafka command-line installation.