Add Version Check to skip log4j1 tasks for C3 Next Gen 2.2.0+#2406
Open
Mihir Chandna (mihirchandna) wants to merge 1 commit into7.9.xfrom
Open
Add Version Check to skip log4j1 tasks for C3 Next Gen 2.2.0+#2406Mihir Chandna (mihirchandna) wants to merge 1 commit into7.9.xfrom
Mihir Chandna (mihirchandna) wants to merge 1 commit into7.9.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a version check in C3 next gen task to skip log4j1-specific tasks when deploying C3 Next Gen 2.2.0 or later.
Control Center Next Gen 2.2.0+ uses log4j2 exclusively (log4j1 was removed) - C3 PR
Running log4j1 configuration tasks on these versions is unnecessary and cause failures when the legacy log4j config files don't exist.
Fixes # (issue)
For CP<7.9.4 the below task for C3 failed silently but from 7.9.5 there is a pipefail command at the start of this task so there is a complete deploy failure, trace below
Ref: https://confluent.slack.com/archives/CMTBL483Y/p1769072706017299
Type of change
How Has This Been Tested?
Couldn't get molecule tests to run on my local
Ran a cp-env job to deploy c3 using this ansible branch: https://semaphore.ci.confluent.io/jobs/4f3c2b22-e5b5-4c40-90c9-5f37ccc1e9ef#L3091
Checklist: