-
Notifications
You must be signed in to change notification settings - Fork 1.1k
KC-1029 updating MRC demo with observer promotion #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomaskwscott thanks for the PR. I made a first pass through docs changes. I have not run the demo yet -- are nightly Docker images stable for 6.1?
Co-authored-by: Yeva Byzek <[email protected]>
Co-authored-by: Yeva Byzek <[email protected]>
Co-authored-by: Yeva Byzek <[email protected]>
Co-authored-by: Yeva Byzek <[email protected]>
Co-authored-by: Yeva Byzek <[email protected]>
|
@jsancio @skaundinya15 -- do you approve this PR? @thomaskwscott thanks for iterating on the feedback. There are a few more comments, were you able to address those (if you agree)? |
@ybyzek I only see 2 outstanding comments that I have already addressed and replied to. Did i miss some? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomaskwscott Interactive will update the MRC diagram next week, so will leave the PR open till then.
Co-authored-by: Yeva Byzek <[email protected]>
Co-authored-by: Yeva Byzek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me, great work @thomaskwscott! Will let @ybyzek give the final sign off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomaskwscott in this PR can you please replace the image at multiregion/docs/images/multi-region-topic-replicas-v2.png with the attached image? Note the slight name change in the legend to use wildcard to describe multiregion async topics (it now includes the new topics created by this PR)
Done! |
|
@thomaskwscott running the PR, my environment produces the following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one QQ, otherwise LGTM. Thanks for the work on this @thomaskwscott!
| multi-region-async-op-under-min-isr: 0 | ||
| multi-region-async-op-under-replicated: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ: Should this have a non zero value if we've promoted observers in this example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but these metrics are shown before region failure and hence no observers have been promoted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skaundinya15 I'm reworking the docs with more JMX meric output, so this will become clearer based on when the JMX metrics are captured. Please stay tuned...PR in progress ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks @thomaskwscott. Looking forward to that @ybyzek 💯
|
@thomaskwscott thomaskwscott#1 is ready for your review & merge. |
PR-857-YB: augment MRC PR for 6.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomaskwscott LGTM, let's ship it!

Description
What behavior does this PR change, and why?
This PR adds observer promotion to the MRC demo
Author Validation
Describe the validation already done, or needs to be done, by the PR submitter.
Reviewer Tasks
Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.
masteror6.1.x