MINOR: Fix log4j2 config property #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
omkreddy
reviewed
Apr 14, 2025
devhritwik
reviewed
Apr 14, 2025
bin/kafka-rest-run-class
Outdated
| # installed | ||
| if [ -e "$base_dir/config/log4j2.yaml" ]; then # Dev environment | ||
| KAFKAREST_LOG4J_OPTS="-Dlog4j.configuration=file:$base_dir/config/log4j2.yaml" | ||
| KAFKAREST_LOG4J_OPTS="-Dlog4j2.configurationFile=file:$base_dir/config/log4j2.yaml" |
There was a problem hiding this comment.
Should we change the variable here and above to either KAFKAREST_LOG4J2_OPTS or use logger for naming consistency? Also # logj4 settings the comment above should read log4j2/logger settings.
There was a problem hiding this comment.
AK uses KAFKA_LOG4J_OPTS and we're already using log4j logging. Leaving this as KAFKAREST_LOG4J_OPTS isn't too bad imo.
airlock-confluentinc
bot
force-pushed
the
fix-log4j2-config
branch
from
d59cd7c to
1298a58
Compare
omkreddy
approved these changes
Apr 14, 2025
devhritwik
approved these changes
Apr 14, 2025
|
Verified that logs were saved to |
devhritwik
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use log4j2 property name.
With the changes in this PR, kafka-rest logs are saved to
/path/to/kafka-rest/logs/kafka-rest.logwhen runningLOG_DIR=/path/to/kafka-rest ./bin/kafka-rest-start ./config/kafka-rest.properties. IfLOG_DIRis not set, logs are saved tologs/kafka-rest.login the current working directory.Follow up of #1368