Skip to content

Conversation

@ayushRanjanCnflt
Copy link
Member

@ayushRanjanCnflt ayushRanjanCnflt commented Jan 2, 2026

Description

What behavior do you want to change, why, how does your patch achieve the changes?

build was failing due to below error

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.0:compile (default-compile) on project ksqldb-common: Compilation failure04:32
[ERROR] /home/semaphore/ksql/ksqldb-common/src/main/java/io/confluent/ksql/util/KsqlConfig.java:[1707,59] cannot find symbol04:32
[ERROR]   symbol:   variable STATE_UPDATER_ENABLED04:32
[ERROR]   location: class org.apache.kafka.streams.StreamsConfig.InternalConfig04:32
[ERROR] -> [Help 1]

on debugging found out that that STATE_UPDATER_ENABLED config has been removed
https://github.com/confluentinc/ce-kafka/commit/23dee0b34df8d7dceab903e8b307bc6a5946b781#diff-07a8a87d3ee84c3e96918aa131033780cf4bc4d4a12ae376e91c059a9e02d229 (see commit description for more info)

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

green pipeline : https://semaphore.ci.confluent.io/workflows/b0516664-6efe-4232-a931-a255b30c5f1a?pipeline_id=b3296610-c06c-4d7b-a160-da313813f3f2

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@ayushRanjanCnflt ayushRanjanCnflt requested a review from a team as a code owner January 2, 2026 06:15
Copilot AI review requested due to automatic review settings January 2, 2026 06:15
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the configuration that enables the Kafka Streams state updater feature by deleting the line that sets STATE_UPDATER_ENABLED to true in the streams configuration defaults.

Key Changes

  • Removed the state updater configuration from KsqlConfig's default Kafka Streams settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1706 to 1707
final Map<String, Object> streamsConfigDefaults = new HashMap<>();
streamsConfigDefaults.put(StreamsConfig.InternalConfig.STATE_UPDATER_ENABLED, true);
streamsConfigDefaults.put(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, KsqlConstants
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of STATE_UPDATER_ENABLED from the default configuration changes the behavior of Kafka Streams state management. This change should be covered by tests that verify the streams configuration defaults no longer include this setting.

Copilot uses AI. Check for mistakes.
@ayushRanjanCnflt ayushRanjanCnflt changed the title [do not merge] Fix master Fix master Jan 5, 2026
Copy link
Member

@VedarthConfluent VedarthConfluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means state updater will be a compulsory feature from 8.3.x

@ayushRanjanCnflt ayushRanjanCnflt merged commit dbf80bd into master Jan 5, 2026
2 of 4 checks passed
@ayushRanjanCnflt ayushRanjanCnflt deleted the master-fix-jan branch January 5, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants