K2 testing final #5198
Open
K2 testing final #5198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: tests/0011-produce_batch.c
…lete.retention.ms
…djusting timeout handling for cloud environments. Added checks for partition existence and refined error handling for GROUP resource configurations, ensuring compatibility with managed Kafka services.
milindl
reviewed
Oct 24, 2025
tests/test.c
Outdated
| * @brief Sleep with configurable multiplier (only if multiplier > 0) | ||
| * @param wait_time Sleep time in seconds | ||
| */ | ||
| void sleep_for(int wait_time) { |
There was a problem hiding this comment.
Rename this to test_, see the other comments made on other test files regarding this function
|
|
||
| RdKafka::MessageTimestamp ts = msg.timestamp(); | ||
| if (ts.type != RdKafka::MessageTimestamp::MSG_TIMESTAMP_CREATE_TIME) | ||
| if (ts.type != RdKafka::MessageTimestamp::MSG_TIMESTAMP_CREATE_TIME && |
There was a problem hiding this comment.
is this a confirmed issue in K2? If so add a comment. AK behaves as expected, if we have timestamp type set as create time correctly, then it will return it correctly also.
There was a problem hiding this comment.
Yes its confirmed bug in K2
…ed metadata synchronization across tests.
…etadata_propagation for delay multipliers.
…ments to replica handling, consumer subscription order, and configuration parameters for topic creation.
…g in tests to ensure stability in cloud environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the librdkafka test suite to improve cloud compatibility by adding configurable options in
test.conf. This enables better test portability and maintainability across different Kafka environments.Changes
1. Configurable Test Framework
test.skip.idempotent: Skip tests requiring idempotent producer (replaces-Iflag)test.supported.acks: Configure supported acknowledgment values (e.g.,-1,0,1)test.sleep.multiplier: Configurable sleep multiplier for different environments. Multiplies explicit sleep_for() delays for cluster state propagation (set 0 to skip sleeps), different from test.timeout.multiplier which multiplies API operation timeouts (can't be disabled).test.timeout.multiplier: Unified timeout scaling (existing feature, now consistently used)test.skip.numbers: Skip specific tests by number (comma-separated list)2. Topic Cleanup
3. Replication Factor
-1)4. Preprocessor Directives for Version Compatibility
🔧 Configuration Examples