Skip to content

Upgrade minimum standards for C and C++ #5212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade minimum standards for C and C++ #5212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .semaphore/semaphore-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ blocks:
type: s1-prod-ubuntu24-04-amd64-1
env_vars:
- name: CFLAGS
value: -std=gnu90 # Test minimum C standard, default in CentOS 7
value: -std=c99 # Test minimum C standard
- name: CXXFLAGS
value: -std=c++98 # Test minimum C++ standard
prologue:
commands:
- '[[ -z $DOCKERHUB_APIKEY ]] || docker login --username $DOCKERHUB_USER --password $DOCKERHUB_APIKEY'
Expand Down
4 changes: 3 additions & 1 deletion .semaphore/semaphore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ blocks:
type: s1-prod-ubuntu24-04-amd64-1
env_vars:
- name: CFLAGS
value: -std=gnu90 # Test minimum C standard, default in CentOS 7
value: -std=c99 # Test minimum C standard
- name: CXXFLAGS
value: -std=c++98 # Test minimum C++ standard
prologue:
commands:
- '[[ -z $DOCKERHUB_APIKEY ]] || docker login --username $DOCKERHUB_USER --password $DOCKERHUB_APIKEY'
Expand Down
17 changes: 4 additions & 13 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,21 +250,12 @@ E.g.:
*Note: The code format style is enforced by our clang-format and pep8 rules,
so that is not covered here.*

## Minimum C standard: "gnu90"
## Minimum C standard: "c99"

This is the GCC default before 5.1.0, present in CentOS 7, [still supported](https://docs.confluent.io/platform/current/installation/versions-interoperability.html#operating-systems)
up to its EOL in 2024.
C99 is fully implemented (except VLA) since Visual Studio 2013 and it's the
default starting from GCC 5.1.0 (available since CentOS 8).

To test it, configure with GCC and `CFLAGS="-std=gnu90"`.

It has the following notable limitations:

* No in-line variable declarations.

**Note**: the "No variable declarations after
statements" (-Wdeclaration-after-statement) requirement has been dropped.
Visual Studio 2012, the last version not implementing C99, has reached EOL,
and there were violations already.
C++ standard is C++98.

## Function and globals naming

Expand Down