Skip to content

Pull latest version of image tags when verifying Linux packages #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emasab wants to merge 6 commits into
base: master
Choose a base branch
from
+19 −14
Open

Pull latest version of image tags when verifying Linux packages #5276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb061d1
Configurable repo url
emasab Dec 16, 2025
1345827
pull: missing
emasab Dec 16, 2025
0cdac87
Enable RH 10
emasab Dec 17, 2025
d7440d6
Include /clients in the default base url
emasab Dec 17, 2025
2d3da94
Disable RH 8
emasab Dec 17, 2025
3008b5f
Using up-to-date Docker Hub image name
emasab Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .semaphore/verify-linux-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ global_job_config:
prologue:
commands:
- checkout
env_vars:
- name: REPOSITORY_BASE_URL
value: "https://packages.confluent.io"

blocks:
- name: "Verify Linux packages (x86_64)"
Expand All @@ -27,7 +24,9 @@ blocks:
- name: "Verify packages"
commands:
- cd packaging/cp
- ./verify-packages.sh ${REPOSITORY_BASE_URL} linux/amd64 ${LIBRDKAFKA_VERSION}
- ./verify-packages.sh
${REPOSITORY_BASE_URL:-https://packages.confluent.io/clients}
linux/amd64 ${LIBRDKAFKA_VERSION}
- name: "Verify Linux packages (aarch64)"
dependencies: []
task:
Expand All @@ -38,4 +37,6 @@ blocks:
- name: "Verify packages"
commands:
- cd packaging/cp
- ./verify-packages.sh ${REPOSITORY_BASE_URL} linux/arm64 ${LIBRDKAFKA_VERSION}
- ./verify-packages.sh
${REPOSITORY_BASE_URL:-https://packages.confluent.io/clients}
linux/arm64 ${LIBRDKAFKA_VERSION}
4 changes: 2 additions & 2 deletions packaging/cp/verify-deb.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ fi
apt-get update
apt-get install -y apt-transport-https wget gnupg2 lsb-release

wget -qO - ${base_url}/clients/deb/archive.key | apt-key add -
wget -qO - ${base_url}/deb/archive.key | apt-key add -

release=$(lsb_release -cs)
cat >/etc/apt/sources.list.d/Confluent.list <<EOF
deb $base_url/clients/deb ${release} main
deb $base_url/deb ${release} main
EOF

apt-get update
Expand Down
10 changes: 5 additions & 5 deletions packaging/cp/verify-packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ thisdir="$( cd "$(dirname "$0")" ; pwd -P )"

verify_debian() {
local version=$2
docker run -v $thisdir:/v $1 /v/verify-deb.sh $base_url $version
docker run --pull missing -v $thisdir:/v $1 /v/verify-deb.sh $base_url $version
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Docker volume mount uses an unquoted variable $thisdir. This should be quoted to prevent issues with paths containing spaces: -v "$thisdir:/v".

Copilot uses AI. Check for mistakes.
deb_status=$?
if [[ $deb_status == 0 ]]; then
echo "SUCCESS: Debian based $1 $2 packages verified"
Expand All @@ -31,7 +31,7 @@ verify_debian() {

verify_rpm() {
local version=$2
docker run -v $thisdir:/v $1 /v/verify-rpm.sh $base_url $version
docker run --pull missing -v $thisdir:/v $1 /v/verify-rpm.sh $base_url $version
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Docker volume mount uses an unquoted variable $thisdir. This should be quoted to prevent issues with paths containing spaces: -v "$thisdir:/v".

Copilot uses AI. Check for mistakes.
rpm_status=$?
if [[ $rpm_status == 0 ]]; then
echo "SUCCESS: RPM $1 $2 packages verified"
Expand All @@ -46,8 +46,9 @@ verify_rpm_distros() {
local version=$2
echo "#### Verifying RPM packages for $platform ####"
# Last RHEL 8 version is 2.4.0
verify_rpm rockylinux:8 "2.4.0"
verify_rpm rockylinux:9 $version
verify_rpm rockylinux/rockylinux:8 "2.4.0"
verify_rpm rockylinux/rockylinux:9 $version
verify_rpm rockylinux/rockylinux:10 $version
}

verify_debian_distros() {
Expand All @@ -56,7 +57,6 @@ verify_debian_distros() {
echo "#### Verifying Debian packages for $platform ####"
verify_debian debian:11 $version
verify_debian debian:12 $version
verify_debian ubuntu:20.04 $version
verify_debian ubuntu:22.04 $version
verify_debian ubuntu:24.04 $version
}
Expand Down
4 changes: 2 additions & 2 deletions packaging/cp/verify-rpm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ fi
cat >/etc/yum.repos.d/Confluent.repo <<EOF
[Confluent-Clients]
name=Confluent Clients repository
baseurl=$base_url/clients/rpm/centos/\$releasever/\$basearch
baseurl=$base_url/rpm/centos/\$releasever/\$basearch
gpgcheck=1
gpgkey=$base_url/clients/rpm/archive.key
gpgkey=$base_url/rpm/archive.key
enabled=1
EOF

Expand Down
4 changes: 4 additions & 0 deletions service.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ semaphore:
- name: LIBRDKAFKA_VERSION
required: true
description: librdkafka version to verify
- name: REPOSITORY_BASE_URL
required: false
description: "Base URL of the package repository to verify packages from.
Defaults to https://packages.confluent.io/clients"
- name: run-all-tests
branch: master
scheduled: false
Expand Down