[KIP-932]: Use separate handles for adminclient apis by PratRanj07 · Pull Request #5388 · confluentinc/librdkafka

Pratyush Ranjan (PratRanj07) · 2026-04-06T11:04:33Z

No description provided.

confluent-cla-assistant · 2026-04-06T11:04:44Z

🎉 All Contributor License Agreements have been signed. Ready to merge.
_{Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.}

Pranav Rathi (pranavrth)

First pass comments.

Pranav Rathi (pranavrth) · 2026-04-06T23:55:25Z

.semaphore/semaphore.yml

+        always:
+          commands:
+            # Upload test 0172 debug log as artifact if it exists (test failed)
+            - '[ -f artifacts/test_0172_debug.log ] && artifact push job artifacts/test_0172_debug.log --destination debug-logs/test_0172_debug_amd64.log || true'


We might need different file name for different runs as newer file will override the new one and we don't have a way to know which job created the file.

Pranav Rathi (pranavrth) · 2026-04-06T23:55:44Z

.semaphore/semaphore.yml

+        always:
+          commands:
+            # Upload test 0172 debug log as artifact if it exists (test failed)
+            - '[ -f artifacts/test_0172_debug.log ] && artifact push job artifacts/test_0172_debug.log --destination debug-logs/test_0172_debug_amd64.log || true'


Update retention to maybe 2 days max.

Pranav Rathi (pranavrth) · 2026-04-07T02:25:25Z

tests/0170-share_consumer_subscription.c

+ * @brief Configure share group using a dedicated producer handle.
+ *        Admin client APIs should not reuse the share consumer handle.
+ */
+static void configure_share_group(const char *group_name,


This is a generic function which can be moved to the common test file. Can be used even for normal consumer.

Use better generic naming.

Move to common test.h and test.c files

make it extensible for other config types as well

Pranav Rathi (pranavrth) · 2026-04-07T02:27:16Z

tests/0170-share_consumer_subscription.c

+ * @brief Delete topic using a dedicated producer handle.
+ *        Admin client APIs should not reuse the share consumer handle.
+ */
+static void delete_topic_admin(const char *topic) {


There is a delete topic function already in test common files. Use that internally. What we want to do is to create a function which deletes topics and doesn't take any parameter. Do this in test commons file as well.

Pranav Rathi (pranavrth) · 2026-04-07T02:28:03Z

tests/0171-share_consumer_consume.c

+ * @brief Configure share group using a dedicated producer handle.
+ *        Admin client APIs should not reuse the share consumer handle.
+ */
+static void configure_share_group(const char *group_name,


Use common function.

Pranav Rathi (pranavrth) · 2026-04-07T02:42:15Z

tests/0172-share_consumer_acknowledge.c

+ * @brief Delete topic using a dedicated producer handle.
+ *        Admin client APIs should not reuse the share consumer handle.
+ */
+static void delete_topic_admin(const char *topic) {


Pranav Rathi (pranavrth) · 2026-04-07T02:45:00Z

tests/0172-share_consumer_acknowledge.c

Remove usage from here as well.

Pranav Rathi (pranavrth) · 2026-04-07T02:46:22Z

tests/0172-share_consumer_acknowledge.c

Let's remove usage of test_share_consumer_get_rk from the tests altogether. Check if we can remove from 0155 as well. Otherwise remove the usage from test.c as well.

In 0155 the test_share_consumer_get_rk is generally used to find the assignments for the particular client instance. I dont think we can remove that usage yet until we modify the underlying functions.

In test.c also it is only used to get the client instance name for the subscribe topics and subscriptions for the logging purpose only. I have changed its usage in the adminclient apis

Pranav Rathi (pranavrth) · 2026-04-07T02:50:59Z

.semaphore/semaphore.yml

      agent:
        machine:
          type: s1-macos-15-arm64-8
+      epilogue:


This need to be enabled in any of the job. I have seen most of the failures in "Linux Ubuntu amd64: integration tests". Check how it can be done.

Pranav Rathi (pranavrth) · 2026-04-07T02:52:07Z

packaging/tools/run-share-consumer-tests.sh

 --version "$TEST_KAFKA_GIT_REF" \
 --cpversion "$TEST_CP_VERSION" \
- --cmd "TESTS_SKIP_BEFORE=0170 python run-test-batches.py $TEST_ARGS")
+ --cmd "TESTS_SKIP_BEFORE=0170 TESTS=0170- python run-test-batches.py $TEST_ARGS" 2>&1 | tee "$DEBUG_LOG")


Why TESTS=0170-?

Pranav Rathi (pranavrth) · 2026-04-07T02:57:47Z

Update the PR title as its already in review. There is a typo in the title. Fix that as well.

Pratyush Ranjan (PratRanj07) requested a review from a team as a code owner April 6, 2026 11:04

airlock-confluentinc bot force-pushed the dev_kip-932_tests_fixing branch from 2548f7a to 838354d Compare April 6, 2026 13:26

Pranav Rathi (pranavrth) added the share consumer label Apr 6, 2026

Pranav Rathi (pranavrth) requested changes Apr 7, 2026

View reviewed changes

Pratyush Ranjan (PratRanj07) changed the title ~~[WIP]: [KIP-932}: Use seperate handles for adminclient apis~~ [KIP-932}: Use separate handles for adminclient apis Apr 8, 2026

airlock-confluentinc bot force-pushed the dev_kip-932_tests_fixing branch from 0d30b3c to 21d15ab Compare April 8, 2026 17:27

Pratyush Ranjan (PratRanj07) changed the base branch from dev_kip-932_queues-for-kafka to dev_kip-932_transaction_and_ctrl_msgs_tests April 8, 2026 17:27

Pratyush Ranjan (PratRanj07) changed the title ~~[KIP-932}: Use separate handles for adminclient apis~~ [KIP-932]: Use separate handles for adminclient apis Apr 8, 2026

Base automatically changed from dev_kip-932_transaction_and_ctrl_msgs_tests to dev_kip-932_queues-for-kafka April 9, 2026 06:18

Pratyush Ranjan (PratRanj07) added 8 commits April 9, 2026 12:09

create seperate rk handle for admin client

ae52579

use common admin and common producer

5d03431

revert timeout change

39937f2

Trying fixing 172 test

ac75c09

only run debug for 172

82d67f2

remove debug logging in files and remove test_share_consumer_get_rk

8b931ae

style fix

0b564fe

Make common producer and admin client for tests

2721688

airlock-confluentinc bot force-pushed the dev_kip-932_tests_fixing branch from 21d15ab to 2721688 Compare April 9, 2026 06:43

Pratyush Ranjan (PratRanj07) added 2 commits April 9, 2026 14:24

remove Debug all to see if this could be causing the issue

969c874

add logging

fa84484

Conversation

Pratyush Ranjan (PratRanj07) commented Apr 6, 2026

Uh oh!

confluent-cla-assistant bot commented Apr 6, 2026

Uh oh!

Pranav Rathi (pranavrth) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pranav Rathi (pranavrth) commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants