Bump version to v2.14.1#5392
Draft
Devarsh Patel (Devarsh010) wants to merge 2 commits intodev_dpatel_s390x_v2.14.1from
Draft
Bump version to v2.14.1#5392Devarsh Patel (Devarsh010) wants to merge 2 commits intodev_dpatel_s390x_v2.14.1from
Devarsh Patel (Devarsh010) wants to merge 2 commits intodev_dpatel_s390x_v2.14.1from
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
|
||
| * Bundle prebuilt binaries for linux-s390x. | ||
|
|
||
|
|
There was a problem hiding this comment.
I think we follow 3 lines difference between release versions.
Member
pranav shah (prashah-confluent)
left a comment
pranav shah (prashah-confluent)
left a comment
There was a problem hiding this comment.
Overall looks good but there is one comment to follow the standard format.
|
|
||
| librdkafka v2.14.1 is a maintenance release: | ||
|
|
||
| * Bundle prebuilt binaries for linux-s390x. |
There was a problem hiding this comment.
Emanuele Sabellico (@emasab) , should we be explicit over here about mentioning QEMU for building the binaries?
Member
pranav shah (prashah-confluent)
left a comment
pranav shah (prashah-confluent)
left a comment
There was a problem hiding this comment.
Changelog check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.