KNET-18079: Upgrade log4j1 to log4j2 #561

shubh-ranade · 2025-04-02T08:25:32Z

AK upgraded to log4j2: KAFKA-9366: Upgrade log4j to log4j2 apache/kafka#17373
log4j.properties files were first converted to xml using the migration tool and then converted to yaml with minor edits
Deleted zookeeper logging configs
Added an explicit dependency following https://logging.apache.org/log4j/2.x/manual/configuration.html#configuration-factories

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)

core/pom.xml: Language not supported
examples/pom.xml: Language not supported
fips-tests/pom.xml: Language not supported

examples/src/main/resources/log4j2.xml

trnguyencflt · 2025-04-02T09:42:45Z

core/pom.xml

        </dependency>
        <dependency>
-            <groupId>org.slf4j</groupId>
-            <artifactId>slf4j-reload4j</artifactId>


is this already declared in top level pom of this project?

I don't think this is declared in top level pom. Should I add it there? Maybe all modules don't need this which could be why it wasn't declared in top level pom.

trnguyencflt · 2025-04-02T09:43:21Z

@shubh-ranade could you please verify the build locally if there is no reload4j in the classpath?

shubh-ranade · 2025-04-02T12:52:02Z

Verified that there is no reload4j dependency

❯ mvn dependency:build-classpath -DincludeArtifactIds=slf4j-reload4j
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.confluent:rest-utils-fips-tests:jar:8.0.0-0
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.bouncycastle:bcpkix-fips:jar -> version ${bouncycastle.bcpkix-fips.version} vs 1.0.7 @ line 93, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] rest-utils-parent                                                  [pom]
[INFO] rest-utils                                                         [jar]
[INFO] rest-utils-test                                                    [jar]
[INFO] rest-utils-example                                                 [jar]
[INFO] rest-utils-package                                                 [pom]
[INFO] rest-utils-fips-tests                                              [jar]
[INFO]
[INFO] -------------------< io.confluent:rest-utils-parent >-------------------
[INFO] Building rest-utils-parent 8.0.0-0                                 [1/6]
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:build-classpath (default-cli) @ rest-utils-parent ---
[INFO] No dependencies found.
[INFO] Dependencies classpath:

[INFO]
[INFO] ----------------------< io.confluent:rest-utils >-----------------------
[INFO] Building rest-utils 8.0.0-0                                        [2/6]
[INFO]   from core/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:build-classpath (default-cli) @ rest-utils ---
[INFO] No dependencies found.
[INFO] Dependencies classpath:

[INFO]
[INFO] --------------------< io.confluent:rest-utils-test >--------------------
[INFO] Building rest-utils-test 8.0.0-0                                   [3/6]
[INFO]   from test/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:build-classpath (default-cli) @ rest-utils-test ---
[INFO] No dependencies found.
[INFO] Dependencies classpath:

[INFO]
[INFO] ------------------< io.confluent:rest-utils-examples >------------------
[INFO] Building rest-utils-example 8.0.0-0                                [4/6]
[INFO]   from examples/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:build-classpath (default-cli) @ rest-utils-examples ---
[INFO] No dependencies found.
[INFO] Dependencies classpath:

[INFO]
[INFO] ------------------< io.confluent:rest-utils-package >-------------------
[INFO] Building rest-utils-package 8.0.0-0                                [5/6]
[INFO]   from package/pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:build-classpath (default-cli) @ rest-utils-package ---
[INFO] No dependencies found.
[INFO] Dependencies classpath:

[INFO]
[INFO] -----------------< io.confluent:rest-utils-fips-tests >-----------------
[INFO] Building rest-utils-fips-tests 8.0.0-0                             [6/6]
[INFO]   from fips-tests/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:build-classpath (default-cli) @ rest-utils-fips-tests ---
[INFO] No dependencies found.
[INFO] Dependencies classpath:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for rest-utils-parent 8.0.0-0:
[INFO]
[INFO] rest-utils-parent .................................. SUCCESS [  0.437 s]
[INFO] rest-utils ......................................... SUCCESS [  0.332 s]
[INFO] rest-utils-test .................................... SUCCESS [  0.030 s]
[INFO] rest-utils-example ................................. SUCCESS [  0.016 s]
[INFO] rest-utils-package ................................. SUCCESS [  0.012 s]
[INFO] rest-utils-fips-tests .............................. SUCCESS [  0.019 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.263 s
[INFO] Finished at: 2025-04-02T18:20:37+05:30
[INFO] ------------------------------------------------------------------------

❯ mvn dependency:tree -Dincludes=org.slf4j:slf4j-reload4j
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for io.confluent:rest-utils-fips-tests:jar:8.0.0-0
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.bouncycastle:bcpkix-fips:jar -> version ${bouncycastle.bcpkix-fips.version} vs 1.0.7 @ line 93, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] rest-utils-parent                                                  [pom]
[INFO] rest-utils                                                         [jar]
[INFO] rest-utils-test                                                    [jar]
[INFO] rest-utils-example                                                 [jar]
[INFO] rest-utils-package                                                 [pom]
[INFO] rest-utils-fips-tests                                              [jar]
[INFO]
[INFO] -------------------< io.confluent:rest-utils-parent >-------------------
[INFO] Building rest-utils-parent 8.0.0-0                                 [1/6]
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:tree (default-cli) @ rest-utils-parent ---
[INFO]
[INFO] ----------------------< io.confluent:rest-utils >-----------------------
[INFO] Building rest-utils 8.0.0-0                                        [2/6]
[INFO]   from core/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:tree (default-cli) @ rest-utils ---
[INFO]
[INFO] --------------------< io.confluent:rest-utils-test >--------------------
[INFO] Building rest-utils-test 8.0.0-0                                   [3/6]
[INFO]   from test/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:tree (default-cli) @ rest-utils-test ---
[INFO]
[INFO] ------------------< io.confluent:rest-utils-examples >------------------
[INFO] Building rest-utils-example 8.0.0-0                                [4/6]
[INFO]   from examples/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:tree (default-cli) @ rest-utils-examples ---
[INFO]
[INFO] ------------------< io.confluent:rest-utils-package >-------------------
[INFO] Building rest-utils-package 8.0.0-0                                [5/6]
[INFO]   from package/pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:tree (default-cli) @ rest-utils-package ---
[INFO]
[INFO] -----------------< io.confluent:rest-utils-fips-tests >-----------------
[INFO] Building rest-utils-fips-tests 8.0.0-0                             [6/6]
[INFO]   from fips-tests/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:tree (default-cli) @ rest-utils-fips-tests ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for rest-utils-parent 8.0.0-0:
[INFO]
[INFO] rest-utils-parent .................................. SUCCESS [  0.427 s]
[INFO] rest-utils ......................................... SUCCESS [  0.310 s]
[INFO] rest-utils-test .................................... SUCCESS [  0.024 s]
[INFO] rest-utils-example ................................. SUCCESS [  0.010 s]
[INFO] rest-utils-package ................................. SUCCESS [  0.008 s]
[INFO] rest-utils-fips-tests .............................. SUCCESS [  0.013 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.196 s
[INFO] Finished at: 2025-04-02T18:14:02+05:30
[INFO] ------------------------------------------------------------------------

Copilot AI review requested due to automatic review settings April 2, 2025 08:25

shubh-ranade requested review from a team as code owners April 2, 2025 08:25

Copilot AI reviewed Apr 2, 2025

View reviewed changes

shubh-ranade added the knet label Apr 2, 2025

trnguyencflt reviewed Apr 2, 2025

View reviewed changes

examples/src/main/resources/log4j2.xml Outdated Show resolved Hide resolved

trnguyencflt reviewed Apr 2, 2025

View reviewed changes

omkreddy approved these changes Apr 2, 2025

View reviewed changes

xuliang2019 approved these changes Apr 3, 2025

View reviewed changes

shubh-ranade added 4 commits April 3, 2025 13:27

Upgrade log4j1 to log4j2

2ed8031

Migrate log4j1 configuration files

cb4afee

Update license

abb70d1

Use yaml configs instead of xml

d3eb498

airlock-confluentinc bot force-pushed the log4j2-migration branch from f688f3c to ec3fa92 Compare April 3, 2025 08:07

Dependency for log4j yaml config

16b7d3b

airlock-confluentinc bot force-pushed the log4j2-migration branch from ec3fa92 to 16b7d3b Compare April 3, 2025 08:24

shubh-ranade enabled auto-merge (squash) April 3, 2025 12:52

trnguyencflt approved these changes Apr 4, 2025

View reviewed changes

shubh-ranade merged commit 4ef2b77 into master Apr 4, 2025
3 of 5 checks passed

shubh-ranade deleted the log4j2-migration branch April 4, 2025 09:54

shubh-ranade mentioned this pull request Apr 7, 2025

KNET-18079: Fix log4j2 pattern config #562

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

KNET-18079: Upgrade log4j1 to log4j2 #561

KNET-18079: Upgrade log4j1 to log4j2 #561

Uh oh!

shubh-ranade commented Apr 2, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

trnguyencflt Apr 2, 2025

Uh oh!

shubh-ranade Apr 2, 2025 •

edited

Loading

Uh oh!

trnguyencflt commented Apr 2, 2025 •

edited

Loading

Uh oh!

shubh-ranade commented Apr 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KNET-18079: Upgrade log4j1 to log4j2 #561

KNET-18079: Upgrade log4j1 to log4j2 #561

Uh oh!

Conversation

shubh-ranade commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trnguyencflt Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

shubh-ranade Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trnguyencflt commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubh-ranade commented Apr 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shubh-ranade commented Apr 2, 2025 •

edited

Loading

shubh-ranade Apr 2, 2025 •

edited

Loading

trnguyencflt commented Apr 2, 2025 •

edited

Loading