Skip to content

Convert XML log4j2 properties files to YAML #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

Convert XML log4j2 properties files to YAML #3663

merged 2 commits into from
Apr 10, 2025

Conversation

@GunalKupta
Copy link
Contributor

@GunalKupta GunalKupta commented Apr 9, 2025 •
edited by atlassian bot
Loading

What

Convert log4j2 properties files to YAML to stay consistent with other CP components and AK: apache/kafka#17373

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Is this change gated behind feature flag(s)?
    • List the LD flags needed to be set to enable this change
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required
    • No code change
  • Does this change require modifying existing system tests or adding new system tests?
    • If so, include tracking information for the system test changes

References

JIRA: DGS-20118

Test & Review

Ran bin/schema-registry-start config/schema-registry.properties

Open questions / Follow-ups

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@GunalKupta GunalKupta marked this pull request as ready for review April 9, 2025 20:17
@Copilot Copilot AI review requested due to automatic review settings April 9, 2025 20:17
@GunalKupta GunalKupta requested a review from a team as a code owner April 9, 2025 20:17
Copilot
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 17 changed files in this pull request and generated 4 comments.

Files not reviewed (8)
  • avro-serializer/src/test/resources/log4j2.xml: Language not supported
  • avro-serializer/src/test/resources/log4j2.yaml: Language not supported
  • benchmark/src/main/resources/log4j2.xml: Language not supported
  • config/log4j2.xml: Language not supported
  • core/src/main/resources/log4j2.xml: Language not supported
  • core/src/test/resources/log4j2.xml: Language not supported
  • protobuf-converter/src/test/resources/log4j2.xml: Language not supported
  • schema-rules/src/test/resources/log4j2.xml: Language not supported
Comments suppressed due to low confidence (2)

core/src/main/resources/log4j2.yaml:30

  • Trailing whitespace in the appender reference could lead to errors when matching appender names; consider removing it.
- ref: stdout

config/log4j2.yaml:39

  • Remove the trailing whitespace from the appender reference for consistency and to avoid potential misconfigurations.
- ref: stdout

schema-rules/src/test/resources/log4j2.yaml Outdated
Root:
level: INFO
AppenderRef:
- ref: stdout No newline at end of file
Copy link

Copilot AI Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace in the appender reference may lead to subtle configuration mismatches. Consider removing the extra space.

Suggested change
- ref: stdout
- ref: stdout

Copilot uses AI. Check for mistakes.

protobuf-converter/src/test/resources/log4j2.yaml Outdated
Root:
level: TRACE
AppenderRef:
- ref: stdout No newline at end of file
Copy link

Copilot AI Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing whitespace from the appender reference to ensure consistent behavior across environments.

Suggested change
- ref: stdout
- ref: stdout

Copilot uses AI. Check for mistakes.

core/src/test/resources/log4j2.yaml Outdated
- name: kafka
level: ERROR
AppenderRef:
- ref: stdout No newline at end of file
Copy link

Copilot AI Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra whitespace at the end of the appender reference may cause issues during configuration parsing. Please remove it.

Suggested change
- ref: stdout
- ref: stdout

Copilot uses AI. Check for mistakes.

benchmark/src/main/resources/log4j2.yaml Outdated

# Disable logging from reflections warning for connect classpath scans
- name: org.reflections
level: ERROR No newline at end of file
Copy link

Copilot AI Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace in the logging level setting might lead to unintended behavior; please trim the extra space.

Suggested change
level: ERROR
level: ERROR

Copilot uses AI. Check for mistakes.

@GunalKupta GunalKupta requested a review from Copilot April 9, 2025 20:23
Copilot
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 17 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • avro-serializer/src/test/resources/log4j2.xml: Language not supported
  • avro-serializer/src/test/resources/log4j2.yaml: Language not supported
  • benchmark/src/main/resources/log4j2.xml: Language not supported
  • config/log4j2.xml: Language not supported
  • core/src/main/resources/log4j2.xml: Language not supported
  • core/src/test/resources/log4j2.xml: Language not supported
  • protobuf-converter/src/test/resources/log4j2.xml: Language not supported
  • schema-rules/src/test/resources/log4j2.xml: Language not supported
Comments suppressed due to low confidence (1)

protobuf-converter/src/test/resources/log4j2.yaml:26

  • The root logger level is set to TRACE here, which is inconsistent with the INFO level used in the other YAML configurations. Verify if this difference is intentional or if it should be standardized for uniformity across modules.
      level: TRACE

@GunalKupta GunalKupta enabled auto-merge (squash) April 9, 2025 20:48
@sonarqube-confluent

This comment has been minimized.

Sign in to view
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (74.10% Estimated after merge)
  • Duplications No duplication information (2.10% Estimated after merge)

Project ID: schema-registry

View in SonarQube

rayokota
rayokota approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GunalKupta GunalKupta merged commit b8829d4 into master Apr 10, 2025
3 of 6 checks passed
@GunalKupta GunalKupta deleted the log4j2/xml-to-yaml branch April 10, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rayokota rayokota rayokota approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GunalKupta @rayokota