Skip to content

Fix GroupRebalanceConfig to take in rack id as an optional arg #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix GroupRebalanceConfig to take in rack id as an optional arg #3752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...java/io/confluent/kafka/schemaregistry/leaderelector/kafka/SchemaRegistryCoordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ public SchemaRegistryCoordinator(
heartbeatIntervalMs,
groupId,
Optional.empty(),
Optional.empty(),
Comment on lines 83 to +84
Copy link

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The duplicated Optional.empty() calls are ambiguous. Consider using named constants or inline comments to clarify which Optional.empty() corresponds to the group instance ID and which to the new rack ID parameter.

Suggested change
Optional.empty(),
Optional.empty(),
GROUP_INSTANCE_ID_EMPTY,
RACK_ID_EMPTY,

Copilot uses AI. Check for mistakes.
retryBackoffMs,
retryBackoffMaxMs,
true
Expand Down