Skip to content

Conversation

@Cerchie
Copy link
Contributor

@Cerchie Cerchie commented Dec 31, 2025

Summary of Changes

This PR adds a createInvalidJarFile util function and then creates another test case where we expect an invalid JAR file to fail to upload.

Note

This PR is branched off cerchie/large-file

%%{init: {'theme': 'forest'}}%%
  gitGraph
      commit id: "103f07e9 (main)"

      branch cerchie/renaming
      checkout cerchie/renaming
      commit id: "7ae2b93346678978c9480206223f295b2b005c3b"

      branch cerchie/large-file
      checkout cerchie/large-file
      commit id: "a4740a84"

      branch cerchie/invalide-file-dimension
      checkout cerchie/invalide-file-dimension
      commit id: "ef22ed07"
Loading

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests

  • Added new
  • Updated existing
  • Deleted existing

Release notes

  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG?

@Cerchie Cerchie requested a review from Copilot December 31, 2025 18:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds test coverage for validating that invalid JAR files are properly rejected during Flink artifact uploads. The changes introduce a new test utility function and an additional test scenario to verify rejection behavior when uploading files that are not valid Java JAR files.

Key Changes:

  • Added createNonJavaJarFile() utility function to generate invalid JAR files for testing
  • Added test case for invalid JAR file upload rejection in the Flink artifacts test suite

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/e2e/utils/flinkDatabase.ts Adds utility function to create invalid JAR files for testing upload validation
tests/e2e/specs/flinkArtifact.spec.ts Adds test scenario for invalid JAR file rejection and updates test description for clarity

@Cerchie Cerchie mentioned this pull request Dec 31, 2025
4 tasks
@Cerchie Cerchie changed the title Draft: Cerchie/invalid file dimension Cerchie/invalid file dimension Dec 31, 2025
Base automatically changed from cerchie/large-file to main January 7, 2026 17:17
@Cerchie
Copy link
Contributor Author

Cerchie commented Jan 7, 2026

closing as we're taking a slightly different approach

@Cerchie Cerchie closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants