-
Notifications
You must be signed in to change notification settings - Fork 17
Cerchie/invalid file dimension #3184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds test coverage for validating that invalid JAR files are properly rejected during Flink artifact uploads. The changes introduce a new test utility function and an additional test scenario to verify rejection behavior when uploading files that are not valid Java JAR files.
Key Changes:
- Added
createNonJavaJarFile()utility function to generate invalid JAR files for testing - Added test case for invalid JAR file upload rejection in the Flink artifacts test suite
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/e2e/utils/flinkDatabase.ts | Adds utility function to create invalid JAR files for testing upload validation |
| tests/e2e/specs/flinkArtifact.spec.ts | Adds test scenario for invalid JAR file rejection and updates test description for clarity |
merging from cerchie/large-file
merging large file branch again
merging from cerchie/large-file
|
closing as we're taking a slightly different approach |
Summary of Changes
This PR adds a
createInvalidJarFileutil function and then creates another test case where we expect an invalid JAR file to fail to upload.Note
This PR is branched off
cerchie/large-file%%{init: {'theme': 'forest'}}%% gitGraph commit id: "103f07e9 (main)" branch cerchie/renaming checkout cerchie/renaming commit id: "7ae2b93346678978c9480206223f295b2b005c3b" branch cerchie/large-file checkout cerchie/large-file commit id: "a4740a84" branch cerchie/invalide-file-dimension checkout cerchie/invalide-file-dimension commit id: "ef22ed07"Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes