VSA signing #2599
Merged
VSA signing #2599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Didn't get to this yet, will aim to have a look tomorrow. |
st3penta
reviewed
Jul 1, 2025
Contributor
st3penta
left a comment
st3penta
left a comment
There was a problem hiding this comment.
The functionality looks good to me, i just left a couple of nitpicks about code style
Introduced support for signing Verification Summary Attestations (VSAs) using a new Signer and Attestor abstraction. The VSA predicate is generated and written to disk, then signed to produce a DSSE envelope. Key changes: - Replaced processVSA and related helpers with explicit use of vsa.NewGenerator, vsa.NewWriter, and vsa.NewSigner - Introduced vsa.NewAttestor to encapsulate VSA signing logic - Signed DSSE envelope is written per component - Output path of the envelope is logged for downstream use These changes lay the foundation for secure VSA publishing by ensuring attestations are signed at generation time. Co-authored-by: Claude Sonnet 4 https://issues.redhat.com/browse/EC-1308
joejstuart
force-pushed
the
ec-1308-refactor
branch
from
d960dac to
f62787e
Compare
st3penta
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the VSA signing, which signs a Verification Summary Attestation (VSA) JSON file using a cosign-compatible private key. This writes a detached, base64-encoded signature alongside the VSA and returns the absolute path to the signature file. It handles key loading, passphrase support, payload reading, signing, and signature persistence with robust error handling.
https://issues.redhat.com/browse/EC-1308