Add script to help bump ubi-minimal base image #2614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbaird
force-pushed
the
add-ubi-bump-script
branch
2 times, most recently
from
e4d02a5 to
ae1014b
Compare
st3penta
reviewed
Jul 1, 2025
hack/ubi-base-image-bump.sh
Outdated
| # Push the branch ready to make a PR | ||
| git push origin $PR_BRANCH:$PR_BRANCH | ||
| # Todo maybe: gh pr create ... | ||
| echo "Be careful to choose the right target branch!" |
Contributor
There was a problem hiding this comment.
This warning comes when everything is already done, i would say you can either remove it, or move up as a confirmation, something like: "You are bumping branch xyz, confirm?"
Contributor
|
Nice! |
simonbaird
force-pushed
the
add-ubi-bump-script
branch
2 times, most recently
from
e2810b9 to
80a4205
Compare
Member
Author
|
I updated the instructions on how to create the PR to make it more obvious.
I think the args are for hacking/debugging purposes only so I feel lazy about document them. 😅 |
I used this script to create three PRs for https://issues.redhat.com/browse/EC-1343 just now.
simonbaird
force-pushed
the
add-ubi-bump-script
branch
from
80a4205 to
a601b07
Compare
Member
Author
|
Thanks for the review! I'll probably merge when/if it goes green (...to resist the urge to keep tweaking it.) |
st3penta
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this script to create three PRs for EC-1343 just now.