refactor: migrate application snapshot VSA to per-image implementatio… #2622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joejstuart
force-pushed
the
appsnapshot-refactor
branch
from
08e99a5 to
390caf3
Compare
st3penta
approved these changes
Jul 22, 2025
Contributor
st3penta
left a comment
st3penta
left a comment
There was a problem hiding this comment.
As far as i understand it, the logic makes sense
internal/applicationsnapshot/vsa.go
Outdated
Comment on lines
86
to
89
| func (g *SnapshotVSAGenerator) GeneratePredicate(ctx context.Context) (Report, error) { | ||
| log.Infof("Generating application snapshot VSA predicate with %d components", len(g.Report.Components)) | ||
|
|
||
| return g.Report, nil |
Contributor
Author
There was a problem hiding this comment.
No, it's being used in the Report. I did rename the receiver variable though to s.
…n and enable signing - Refactored ApplicationSnapshot VSA generation to use the per-image VSA generation logic - Simplified snapshot-level VSA flow by reusing component-level signing implementation - Added support for signing ApplicationSnapshot VSAs using the same key and process as per-image VSAs - Removed legacy snapshot-specific logic that is now redundant Co-authored-by: OpenAI GPT-4.1 <[email protected]>
joejstuart
force-pushed
the
appsnapshot-refactor
branch
from
390caf3 to
e3a15cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/EC-1359
Co-authored-by: OpenAI GPT-4.1 [email protected]