Skip to content

Remove "effective_on" from trusted_tasks #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dheerajodha merged 1 commit into from
Jul 25, 2025
Merged

Remove "effective_on" from trusted_tasks #2630

dheerajodha merged 1 commit into from
Jul 25, 2025

Conversation

@dheerajodha
Copy link
Contributor

@dheerajodha dheerajodha commented Jul 14, 2025

resolves: EC-423

@dheerajodha dheerajodha marked this pull request as ready for review July 15, 2025 14:16
dheerajodha
dheerajodha commented Jul 16, 2025
View reviewed changes
dheerajodha
dheerajodha commented Jul 16, 2025
View reviewed changes
@simonbaird
Copy link
Member

simonbaird commented Jul 16, 2025

The acceptance timeout should be fixed if you give it a rebase.

@dheerajodha dheerajodha force-pushed the EC-423 branch 2 times, most recently from 5115a99 to d535558 Compare July 18, 2025 14:35
@dheerajodha
Copy link
Contributor Author

dheerajodha commented Jul 18, 2025

The acceptance timeout should be fixed if you give it a rebase.

Thanks! Now the current failure is due to my changes. Pushing a new commit, apologies.

st3penta
st3penta reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 22, 2025
View reviewed changes
Copy link
Member

@simonbaird simonbaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments and questions.

@dheerajodha dheerajodha force-pushed the EC-423 branch 3 times, most recently from 4eac6b4 to 76eddb6 Compare July 23, 2025 13:24
@dheerajodha
Copy link
Contributor Author

dheerajodha commented Jul 23, 2025

acceptance tests failed on:

Failed to get image auth for docker.io. Setting empty credentials for the image: docker.io/ynohat/git-http-backend. Error is: credentials not found in native keychain

and konflux build PLR failed on unrelated issue, retesting:
/retest

@dheerajodha
Copy link
Contributor Author

dheerajodha commented Jul 23, 2025

/retest

simonbaird
simonbaird reviewed Jul 23, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 23, 2025
View reviewed changes
simonbaird
simonbaird reviewed Jul 23, 2025
View reviewed changes
simonbaird
simonbaird approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@simonbaird simonbaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, apart from the "backwards compatibility" suggestion.

@simonbaird
Copy link
Member

simonbaird commented Jul 23, 2025

Nice patch!

@dheerajodha dheerajodha force-pushed the EC-423 branch 2 times, most recently from a2b23f0 to e675723 Compare July 24, 2025 11:24
@dheerajodha
remove effective_on attribute from tracker, use expires_on only
a0a6fa1 
- Remove effective_on field from taskRecord struct
- Replace effective_on logic with expires_on-only approach
- Most recent record (index 0) have no expires_on (always valid)
- Previously demoted records get expiry based on demotion time + inEffectDays
- Use --in-effect-days flag to set expiry of relevant records
- Update all tests to reflect new expires_on-only behavior

resolves: EC-423
@dheerajodha
Copy link
Contributor Author

dheerajodha commented Jul 25, 2025

Merging this since I addressed all the comments and got approvals.
Thank you for the reviews!

@dheerajodha dheerajodha merged commit c542c80 into conforma:main Jul 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonbaird simonbaird simonbaird approved these changes

@st3penta st3penta st3penta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dheerajodha @simonbaird @st3penta