Improve EC Task log clarity and ordering #2647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbaird
reviewed
Jul 22, 2025
tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml
Outdated
Show resolved
Hide resolved
simonbaird
reviewed
Jul 22, 2025
tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml
Outdated
Show resolved
Hide resolved
simonbaird
reviewed
Jul 22, 2025
tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml
Outdated
Show resolved
Hide resolved
simonbaird
reviewed
Jul 22, 2025
| volumeMounts: | ||
| - mountPath: /var/workdir | ||
| name: workdir | ||
| onError: continue |
Member
There was a problem hiding this comment.
Nitpick: Move the before the command to be consistent with the other steps.
simonbaird
reviewed
Jul 22, 2025
tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml
Outdated
Show resolved
Hide resolved
Member
|
About the acceptance test failure: I can see a bunch of |
simonbaird
reviewed
Jul 22, 2025
tasks/verify-enterprise-contract/0.1/verify-enterprise-contract.yaml
Outdated
Show resolved
Hide resolved
dheerajodha
force-pushed
the
EC-1360
branch
2 times, most recently
from
cbf6b10 to
0f06a8c
Compare
Contributor
Author
|
@simonbaird FYI, here's the Conforma based on the changes from this PR: conforma-ec-423-d87z9-verify.log |
Moves Enterprise Contract validation results to the end of the task logs in Konflux UI for immediate visibility. This was achieved by: * Correcting ec validate's --output text syntax to write results directly to a file (text=<path>?show-successes=false). * Introducing a new detailed-report step at the end of the Task to simply cat this file, ensuring final output position. resolves: EC-1360
The 'info' step, previously a visual cue for log sections to ignore (referencing EC-1206), is now obsolete. With critical validation results moved to the log's end for immediate visibility, this indicator no longer serves its original purpose. resolves: EC-1360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: EC-1360