Skip to content

Conversation

@ascerra
Copy link
Contributor

@ascerra ascerra commented Jul 22, 2025

Description

Adding
DOCKER_BUILDKIT: 1
COMPOSE_DOCKER_CLI_BUILD: 1
to the acceptance test env field fixes the timeout issue we were seeing.

I believe this regressions could come from an update in either ubunut-latest image or podman as we are pulling latest changes for both each time we run.

Testing

This has been tested in my mirror of the cli repo

See the many passing actions with this change in place
https://github.com/ascerra/cli-mirror/actions/workflows/checks-sealights.yaml

Assisted by: Cursor AI

Adding
  DOCKER_BUILDKIT: 1
  COMPOSE_DOCKER_CLI_BUILD: 1
to the acceptance test env field fixes the timeout issue we were seeing.

Assisted by: Cursor AI
Signed-off-by: Adam Scerra <[email protected]>
@simonbaird
Copy link
Member

Related to https://issues.redhat.com/browse/EC-1400 IIUC.

@simonbaird
Copy link
Member

/ok-to-test

@simonbaird
Copy link
Member

Hmm, it won't actually run the new acceptance tests in this PR, since Sealights runs with "pull_request_target", so it uses the main branch workflows.

@ascerra
Copy link
Contributor Author

ascerra commented Jul 22, 2025

@simonbaird right this is a limitation due to security concerns of having a workflow that relies on a secret

This is why I provided https://github.com/ascerra/cli-mirror/actions/workflows/checks-sealights.yaml

to show this change merged into a mirror of this repo as my way of testing

@cuipinghuo
Copy link
Contributor

cuipinghuo commented Jul 22, 2025

Hmm, it won't actually run the new acceptance tests in this PR, since Sealights runs with "pull_request_target", so it uses the main branch workflows.

The main branch workflow has Acceptance as required. To merge the change in this pr, I disable acceptance. Am I doing right? @simonbaird If you don't have any other concerns, let's merge.

@cuipinghuo cuipinghuo merged commit 519d66f into conforma:main Jul 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants