Fix step_images.step_images_accessible check #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This fix is correct, but if we merge it, we will break the CI of the build-definitions repo. We need to figure out how to proceed there. |
Contributor
|
Can we add effective on to the rule? Say give a leeway of 30 days? |
zregvart
approved these changes
Nov 28, 2024
Although the implementation of ec.oci.image_manifest does return nil if the Image Manifest is not found, rego converts that to no value at all. Thus, asserting that the returned value is nil will never be true causing this policy rule to always pass. This commit changes the rule evaluation to check for the lack of a value instead. Signed-off-by: Luiz Carvalho <[email protected]>
lcarva
force-pushed
the
fix-step-image-check
branch
from
e8075c2 to
ff82142
Compare
Contributor
Author
|
The issue on build-definitions was resolved by making sure the registry auth was provided to EC. Moving it out of draft. Added an effective_on to the policy rule for |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the implementation of ec.oci.image_manifest does return nil if the Image Manifest is not found, rego converts that to no value at all. Thus, asserting that the returned value is nil will never be true causing this policy rule to always pass.
This commit changes the rule evaluation to check for the lack of a value instead.