Skip to content

Fix step_images.step_images_accessible check #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcarva merged 1 commit into from
Dec 2, 2024
Merged

Fix step_images.step_images_accessible check #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions antora/docs/modules/ROOT/pages/task_policy.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Confirm that each step in the Task uses a container image that is accessible.
* Rule type: [rule-type-indicator failure]#FAILURE#
* FAILURE message: `Step %d uses inaccessible image ref '%s'`
* Code: `step_images.step_images_accessible`
* Effective from: `2025-01-10T00:00:00Z`
* https://github.com/enterprise-contract/ec-policies/blob/{page-origin-refhash}/policy/task/step_images/step_images.rego#L14[Source, window="_blank"]

[#step_image_registries_package]
Expand Down
3 changes: 2 additions & 1 deletion policy/task/step_images/step_images.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,14 @@ import data.lib
# solution: >-
# Make sure the container image used in each step of the Task is pushed to the
# registry and that it can be fetched.
# effective_on: 2025-01-10T00:00:00Z
#
deny contains result if {
input.kind == "Task"

some step_index, step in input.spec.steps
image_ref := step.image
is_null(ec.oci.image_manifest(image_ref))
not ec.oci.image_manifest(image_ref)

result := lib.result_helper_with_term(
rego.metadata.chain(),
Expand Down
2 changes: 1 addition & 1 deletion policy/task/step_images/step_images_test.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ test_task_with_invalid_steps if {
mock_image_manifest(ref) := m if {
startswith(ref, "registry.io/repository/ok")
m := {}
} else := null
}
Loading