Handle required tasks data more consistently#1672
Draft
simonbaird wants to merge 1 commit intoconforma:mainfrom
Draft
Handle required tasks data more consistently#1672simonbaird wants to merge 1 commit intoconforma:mainfrom
simonbaird wants to merge 1 commit intoconforma:mainfrom
Conversation
simonbaird
force-pushed
the
top-level-rule-data
branch
3 times, most recently
from
359adb1 to
db3c358
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
simonbaird
force-pushed
the
top-level-rule-data
branch
from
db3c358 to
c0349ee
Compare
st3penta
reviewed
Feb 25, 2026
Comment on lines
+167
to
+170
| # Special handling for "pipeline-required-tasks" and "required-tasks" since they | ||
| # were placed at the top level historically. Note that we can't use data[key_name] | ||
| # since it evaluates at run-time and we get a recursion error because `data` | ||
| # includes this (and all) code, which tries to evaluate `data`, and so on. |
Contributor
There was a problem hiding this comment.
IIUC this test case is for retrocompatibility, but the new policy configs have these keys under data.rule_data, correct?
Maybe we could add a deprecation warning so users can update their configs and we can clean this up sometime in the future?
st3penta
requested changes
Feb 25, 2026
Contributor
|
(i didn't want to request any changes 😅 i just wanted to leave the comment) |
Contributor
|
LGTM, and it also aligns with the spirit of the lib data top level cleanup (https://issues.redhat.com/browse/EC-1651) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we should move
data["pipeline-required-tasks"]todata.rule_data["pipeline-required-tasks"], which means this won't be needed any more, but this change should make it easier to transition I guess.