Skip to content

Conversation

Maxetto
Copy link
Contributor

@Maxetto Maxetto commented Jun 14, 2017

not tested

@connection-lost
Copy link
Owner

connection-lost commented Jun 14, 2017

Um, I am confused here.
What is the relationship between Factions from MassiveCraft and FactionsUUID (https://www.spigotmc.org/resources/factionsuuid.1035/)?

@Maxetto
Copy link
Contributor Author

Maxetto commented Jun 14, 2017

FactionsUUID is a fork of the 1.6.x branch from MassiveCraft.

Here's the source code: https://github.com/drtshock/Factions

@Maxetto
Copy link
Contributor Author

Maxetto commented Jun 14, 2017

I'm pretty sure this error report (https://pastebin.com/zgqDHc1F) from XxDawnsusxX is due to the use of FactionsUUID (They share the same Plugin Name, since it's a fork as I said).

Also because he asked if the plugin had FactionsUUID support: https://www.spigotmc.org/threads/lockettepro-uuid-support.133105/page-16#post-2423200

@connection-lost
Copy link
Owner

I will give this a shot.

@connection-lost
Copy link
Owner

Appreciate your effort, but unfortunately I decide not to support FactionsUUID for now. Supporting two plugins with same plugin name and different package names... too messy. And yet I doubt the effort to maintain FactionUUID support will worth it... Also the plugin itself costs $15 and lack of API documentation... meh...
Sorry again for rejecting this pull request.

@Maxetto
Copy link
Contributor Author

Maxetto commented Jun 17, 2017

@connection-lost I understand the trouble of supporting two forks of the same plugin.
Yet, the plugin is Free if you can build it and many people use that because they like how Factions behaved in 1.6.9.5.

If my fix does work, I suggest you to add it as it's a fire-and-forget addition (FactionsUUID won't likely change anything of their API).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants