Skip to content

Conversation

stan60250
Copy link

Added language Chinese(traditional) and disable in specific worlds feature.

@ljacqu
Copy link

ljacqu commented Jun 19, 2017

-1

This repeats the same line of code over and over -> should be its own method

@connection-lost
Copy link
Owner

Its own method

The isLockable(Block block) and isLocked(Block block) method in LocketteProAPI.java to the rescue. We only need to add the world check code twice.

@connection-lost
Copy link
Owner

One more thing:
What's with those "ignoreCancelled" you just added? Was that intentional?

@stan60250
Copy link
Author

stan60250 commented Jun 20, 2017

Yes. I replaced if (event.isCancelled()) return; with @EventHandler(ignoreCancelled = true)
It's same but is it much more easier?
https://bukkit.org/threads/ignore-cancelled-events.61155/
https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/event/EventHandler.html

@connection-lost
Copy link
Owner

Ah I see.

Pawned and others added 5 commits July 16, 2017 09:19
Clan Tags are not case-sensitive (i.e. 1 user cannot have clan tag "Test" and another user have a clan with tag "TeSt")
This update just makes it easier to give their clan members access as we found that .getTag() returns the tag in all lowercase while users were used to typing their tag with whatever casing they usually have on their tag.
Ignore case-sensitivity on Clan Tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants