Add doc on streaming #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
force-pushed
the
streaming-docs
branch
from
6e37f59 to
5a6144c
Compare
stefanvanburen
approved these changes
Sep 30, 2025
Member
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
lgtm, think we can just ditch the go-specific option unless we really want to stay in sync with the upstream (I don't think we need to)
docs/streaming.md
Outdated
Comment on lines
76
to
77
| option go_package = "example/gen/greet/v1;greetv1"; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| option go_package = "example/gen/greet/v1;greetv1"; |
Collaborator
Author
There was a problem hiding this comment.
Definitely, thanks for noticing
Member
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
lgtm other than DCO check; force push w/ a signed commit and I'll stamp?
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
force-pushed
the
streaming-docs
branch
from
96c03ac to
47543fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Go docs but omits headers and interceptors sections since here there is no difference for headers based on stream type, and the streaming interceptor payload interceptors are document in
interceptors.md.