Skip to content

Do multiple reads for WSGI even with content length #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
+29 −1
Merged

Do multiple reads for WSGI even with content length #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0e1cb
Do multiple reads for WSGI even with content length
anuraaga Oct 21, 2025
f5f1139
Raise error on truncated and optimize for prebuffered
anuraaga Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/connectrpc/_server_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,34 @@ def prepare_response_headers(
return headers


def _read_body_with_content_length(
environ: WSGIEnvironment, content_length: int
) -> bytes:
input_stream: BytesIO = environ["wsgi.input"]

# Many app servers buffer the entire request before executing the app
# so do an optimistic read before looping.
chunk = input_stream.read(content_length)
if len(chunk) == content_length:
return chunk

bytes_read = len(chunk)
chunks = [chunk]
while bytes_read < content_length:
to_read = content_length - bytes_read
chunk = input_stream.read(to_read)
if not chunk:
break
chunks.append(chunk)
bytes_read += len(chunk)
if bytes_read < content_length:
raise ConnectError(
Code.INVALID_ARGUMENT,
f"request truncated, expected {content_length} bytes but only received {bytes_read} bytes",
)
return b"".join(chunks)


def _read_body(environ: WSGIEnvironment) -> Iterator[bytes]:
input_stream: BytesIO = environ["wsgi.input"]
while True:
Expand Down Expand Up @@ -257,7 +285,7 @@ def _handle_post_request(
content_length = environ.get("CONTENT_LENGTH")
content_length = 0 if not content_length else int(content_length)
if content_length > 0:
req_body = environ["wsgi.input"].read(content_length)
req_body = _read_body_with_content_length(environ, content_length)
else:
req_body = b"".join(_read_body(environ))

Expand Down