Skip to content

Add token permissions to main CI for TestPyPi #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

Add token permissions to main CI for TestPyPi #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dda742
Add id token to main CI for TestPyPi
anuraaga Sep 23, 2025
a8f0b6a
Add attestations too
anuraaga Sep 23, 2025
f5c4d78
Remove sed
anuraaga Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
name: CI
permissions:
contents: read
on:
push:
branches:
- main
pull_request:
workflow_dispatch:

permissions:
contents: read
attestations: write
id-token: write

concurrency:
# Cancel in-progress jobs for PRs only
group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && github.sha || github.ref }}
Expand Down Expand Up @@ -101,14 +104,6 @@ jobs:

- run: uv sync --frozen

- name: Modify package name for TestPyPI
Copy link
Collaborator Author

@anuraaga anuraaga Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this since it seems we may be able to use the correct package name thanks to @mattrobenolt's help

run: |
# The 'connect-python' name is claimed on TestPyPI. No big
# deal, we can use a different name since this is just to test
# publishing really.
# TODO: Update now that this is in connectrpc
sed -i 's/name = "connect-python"/name = "firetiger-connect-python"/' pyproject.toml

- run: uv build

- name: build codegen archives
Expand All @@ -133,5 +128,6 @@ jobs:
uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4
if: github.event_name != 'pull_request'
with:
repository-url: https://test.pypi.org/legacy/
packages-dir: protoc-gen-connect-python/dist
skip-existing: true