-
Notifications
You must be signed in to change notification settings - Fork 25
Fix spurious console log errors (Uncaught SyntaxError: Unexpected token o in JSON at position 1) #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On the console you'll see a lot of errors like this: > Uncaught SyntaxError: Unexpected token o in JSON at position 1 The reason for that can be found here: PrismJS/prism#1303 This PR applies the recommended fix for that thread and also tried with this PR: conorhastings#32 The fix is to add a prism-config.js that sets `disableWorkerMessageHandler: true` Fixes conorhastings#12
It didn't help me. I still get an error. Are you sure it works? |
It worked for me? How did you test it? |
Done in exactly the same way, in the debug mode there is still an error. |
Looks like the misunderstanding of how to test the patch was answered here: #32 (comment) @conorhastings, what would it take to get this PR merged? |
@conorhastings Ping on what it would take to get this merged? |
@chrisglein sorry i haven't used this library in a long time, i invited you as a collaborator, if there is some permission i missed please let me know but happy to give you merge ability, if you give me your npm handle i can add you three as well |
I accepted the invite, thanks. Happy to try to help. For npm, this is me. |
@chrisglein invited you as a maintainer, let me know if it didnt go through |
Does it mean that the library has an active maintainer? |
As someone who's using the module, I'll try to help out. But there's a lot on my plate. |
I created a PR, but someone needs to merge it and release a new version. Anyway, I created a fork and published it to NPM with my fix included. This is the only way to handle unmaintained projects. |
On the console you'll see a lot of errors like this:
The reason for that can be found here:
PrismJS/prism#1303
This PR applies the recommended fix for that thread and also tried with this PR: #32
The fix is to add a prism-config.js that sets
disableWorkerMessageHandler: true
Fixes #12