feature: decouple strategyData from GenericSwapData #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NIC619
reviewed
Dec 17, 2024
NIC619
approved these changes
Dec 17, 2024
alex0207s
force-pushed
the
feature/decouple-strategy-data
branch
from
28e2e2e to
b19ecbf
Compare
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strategyDatais time-sensitive, and including it in theGenericSwapDatastruct would make the entire order time-restricted. By decouplingstrategyData, the order becomes more flexible, ensuring that the user's intent to exchange tokens remains unchanged while avoiding the need to repeatedly sign the same exchange intent with differentstrategyData.