veLON contract with early withdrawal penalty #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeqing-guo
commented
Jul 15, 2022
zeqing-guo
commented
- Forked from veMULTI
- Supported early withdrawal penalty
- Add some foundry test cases:
- initializing the project
- testing staking
- testing early withdrawal
- Improve the coding style
|
It would be great if commit 33261c3 can be split into two: first copy ve.sol and second apply changes on top. Then we can review second commit and see the new changes applied to ve.sol. |
|
After discussion, I'll refactor the implementation in another PR. Keep this one opened for now so new feature and test can be added without being blocked. |
|
Let's keep this PR opened as a reference until refactored implementation get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.