Fix prevent unwanted semicolon insertion #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Comment on lines
1100
to
+1103
| const newLine = event.document.lineAt(newLineNumber); | ||
| if (newLine.text.trim().length > 0) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
[P1] Dot prefix no longer added when splitting a line
The new guard skips auto‑continuation whenever the target line already contains non‑whitespace characters. This prevents semicolons from being injected during move‑line operations, but it also disables dot prefix propagation for normal editing when a user presses Enter in the middle of a dot‑prefixed statement (the new line initially contains the trailing text, so trim().length is >0). The result is a new line that lacks the required leading dots, leaving the block at the wrong indentation level and forcing the user to fix syntax manually.
Useful? React with 👍 / 👎.
LeoAnders
pushed a commit
that referenced
this pull request
Oct 7, 2025
Fix unwanted semicolon insertion in ObjectScript dot-prefixed blocks: auto-continuation now inserts the copied prefix only when the target line is empty and preserves ; only if it existed on the previous line, and a regression test ensures moving lines across dot-prefixed semicolon comments does not inject semicolons.
LeoAnders
added a commit
that referenced
this pull request
Oct 7, 2025
* feat: enable cross-workspace definition lookup * feat: add ObjectScript enter rules for semicolon continuation * feat: auto-indent dot syntax on enter for `.mac` / `.int` routines * feat: add resolveContextExpression command `Ctrl+Alt+Space` to call API and insert returned code * fix: error Insert `enter` prettier/prettier * Chore API restructure to use request util (#9) * chore (api): restructure to use request util * docs: add changelog entry for API refactor * style: fix prettier formatting issues * ci: add `target_commitish` to correctly reference commit in prerelease tags * refactor: reorganize CCS module layout * feat: add `core` and centralized `config` scaffolds * feat: add ContextExpressionClient and centralize route handling - Introduced ContextExpressionClient to encapsulate API calls for \/resolveContextExpression\, applying settings, timeout and logging - Updated contextHelp.ts to consume the new client instead of creating SourceControlApi manually - Added routes.ts with BASE_PATH and resolveContextExpression route - Updated extension.ts to import CCS commands/providers from barrel - Adapted SourceControlApi client to use centralized routes (only resolveContextExpression for now) * feat: reorganize SourceControl API with dedicated clients folder * Fix prevent unwanted semicolon insertion (#13) Fix unwanted semicolon insertion in ObjectScript dot-prefixed blocks: auto-continuation now inserts the copied prefix only when the target line is empty and preserves ; only if it existed on the previous line, and a regression test ensures moving lines across dot-prefixed semicolon comments does not inject semicolons. * Feat add Ctrl+Q to fetch global documentation from selection and print to Output (#17) Add Ctrl+Q shortcut to fetch global documentation for the current selection/line and print the response to the Output. * Unify Go to Definition(F12) and Ctrl+Click through CCS API resolution (#20) * revert: remove cross-workspace definition lookup (45b7b82) * feat: add API-based Go to Definition command and integrate with keybinding - Introduced DefinitionResolverClient for REST API resolution - Implemented definitionLookup feature (extractQuery + lookup) for robust query handling - Added `PrioritizedDefinitionProvider` to prefer CCS resolver before fallback - Implemented new command vscode-objectscript.ccs.goToDefinition with API-first fallback - Updated package.json to bind F12 and menus to the new command for ObjectScript files - Registered new command in extension.ts and integrated telemetry - New goToDefinitionLocalFirst command integrates CCS API before native definition * feat: support cross-namespace definition lookup and request logging * feat: implement full Ctrl+Click support with `CCS API` resolution * feat: remove visual underline from `DocumentLinks` in `DefinitionDocumentLinkProvider` * chore: add dedicated CHANGELOG.md for internal Consistem updates --------- Co-authored-by: Ricardo Alves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unwanted semicolon insertion in ObjectScript dot-prefixed blocks: auto-continuation now inserts the copied prefix only when the target line is empty and preserves
;only if it existed on the previous line, and a regression test ensures moving lines across dot-prefixed semicolon comments does not inject semicolons.