Context help return adjustment #56
Conversation
RicardoASJunior
commented
Nov 5, 2025
RicardoASJunior
commented
- Added logic to detect and handle non-replacement (documentation-style) responses
- Improved data rendering for global-style API returns
- Maintained existing behavior for rule/command substitution responses
- Updated internal typing and handling flow for consistent context help output
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!hasGifCommand) { | ||
| const eol = document.eol === vscode.EndOfLine.CRLF ? "\r\n" : "\n"; | ||
| const textExpression = normalizedTextExpression.replace(/\r?\n/g, eol); | ||
| const formattedTextExpression = textExpression; | ||
|
|
There was a problem hiding this comment.
--gif context expressions still replace text
The new guard if (!hasGifCommand) means the editor only performs a replacement when the context expression does not include --gif. With --gif present the command now skips editor.edit entirely and only shows the GIF, leaving the original context expression untouched. In the previous version the text was replaced for GIF responses as well, so this change regresses the command’s primary output. Users invoking --gif now see a webview but no text insertion, which likely wasn’t intended for a substitution-style response.
Useful? React with 👍 / 👎.
