refactor: replace thiserror with a manual impl
#327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @djc |
djc
approved these changes
Aug 21, 2025
|
Until I have crates.io privileges for this crate, there is not much point in merging. |
|
@djc Thanks for your information and really thanks for your maintenance on these crates .. So we still need to have some time from @mitsuhiko or @pksunkara to add a new crate owner? Do you have their contact to notify them this case? |
|
I asked @mitsuhiko on July 25th -- I just pinged him with a reminder. (If your projects depend on this kind of maintenance, please have your organization(s) sponsor my work.) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #318 as there's no need to update
thiserrorif it's no longer used 😁It was easy enough to match the functionality provided by
thiserrorwith a manual implementation instead