add support for compileString() method in scssphp 1.5 and above#1043
Open
stklcode wants to merge 1 commit intoconsolidation:5.xfrom
Open
add support for compileString() method in scssphp 1.5 and above#1043stklcode wants to merge 1 commit intoconsolidation:5.xfrom
stklcode wants to merge 1 commit intoconsolidation:5.xfrom
Conversation
The SCSS task uses Compiler::compile() which is deprecated in current scssphp. Add support for new compileString() method which returns a result object instead of string.
stklcode
force-pushed
the
feature/scssphp-compilestring
branch
from
d84b949 to
1cc58a0
Compare
stklcode
force-pushed
the
feature/scssphp-compilestring
branch
from
1cc58a0 to
dd3e1ea
Compare
|
What is the status of this? scssphp 2.0 has removed the |
Author
|
Friendly ping @greg-1-anderson I know this PR is quite old, back from the 3.x days, and the SCSS task is probably none of the top used features, but I guess the compatibility fix is still valid. If there’s something blocking or additional improvement in the wishlist, I’d offer do dig into it again. Otherwise feel free to either merge or close it as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
Add support for new
compileString()method which returns a result object instead of string.Description
The SCSS task uses
Compiler::compile()which is deprecated in current scssphp.Check, if
compileString()is available and use it, if so.This change does not break compatibility with
scssphp/scssphp ~1.0.0, but eliminates the deprecation warning with 1.5 and above.Could probably ease extension for source map, because the
CompilationResulthas agetSourceMap()method to access the output from the very same result object.