Use error output as TaskExitException message#1157
Open
prudloff-insite wants to merge 1 commit intoconsolidation:5.xfrom
Open
Use error output as TaskExitException message#1157prudloff-insite wants to merge 1 commit intoconsolidation:5.xfrom
prudloff-insite wants to merge 1 commit intoconsolidation:5.xfrom
Conversation
Contributor
Author
|
@greg-1-anderson Would you be able to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
Fixes #1153.
Description
TaskExitExceptioncontains STDOUT, which causes the stand output to be displayed twice and the actual error message to be buried between it.Making the exception contain STDERR ensure the error message is the last thing printed, so the can find it easily. (It also makes more sense semantically that an exit exception contains the error output.)
With the patch
Without the patch