Nullable types must be explicit in 4.x.#1172
Closed
Conversation
Member
|
The 5.x branch is already compatible with PHP 8.4. If we merged this here, I'm not sure that this alone would make the 4.x branch compatible. I'm not sure that the 4.x branch can be made compatible in a backwards-compatible way. You should upgrade to the 5.x branch. |
Author
|
I have to use 4.x because I use Drupal 10.4 on PHP 8.4 and I can't use 5.x version there because of dependency restrictions. I just added diff of this PR as a patch and now I don't see any deprecation messages. It's enough for my goals, anyway thanks for the response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
Nullable types must be explicit in 4.x branch to provide compatibility with PHP 8.4.