CLI-1484: Ignore non-phar release assets#37
Merged
danepowell merged 2 commits intoconsolidation:mainfrom Oct 29, 2025
Merged
Conversation
Collaborator
Author
|
I guess not everyone uses a phar extension, I'm checking for octet stream instead; this at least allows us to upload non-phar assets as zipped binaries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acquia CLI is going to start release native binaries in addition to phar assets for its releases. This is problematic because the self-updater doesn't currently consider the asset type before blindly attempting to update to it.
This PR fixes that by ensuring only assets with a
pharfile extension are downloaded.