Use calc_element() to get ticks length
#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I merged the change and will submit to CRAN later today :) |
|
|
|
Lovely, thank you Constantin! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Constantin,
Good to see you yesterday!
Unfortunately today, I'm the bearer of bad news that I found a revdep error in ggplot2 that involved {ggupset}, tracked in tidyverse/ggplot2#6287.
The good news is that this PR should fix it!
We've not set ourselves a deadline yet on when we want to release the next ggplot2 version, but I imagine it is a few months away.
Cheers!