Multi/parser #129
Merged
Multi/parser #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy TypeScript type definitions from types/*/dist/ during build - Update import paths to use local ./types instead of @pgsql/types - Make parser package completely self-contained with all necessary types - Update PUBLISH.md to document the types bundling process
- Replace @pgsql/types with ./types in all .js, .cjs, and .d.ts files - Use global regex replacement for comprehensive coverage - Cleaner and more maintainable approach
- Document that parser is self-contained with bundled types - Explain the types bundling process - Note that no external @pgsql/types dependency is needed
- Download all WASM artifacts (v13-v17) for parser build - Build types packages before building parser (required for bundling) - Ensure test-parser job has all required artifacts - Fixes MODULE_NOT_FOUND error for v13/index.cjs in CI
- Change test script from 'node --test test/*.test.js' to 'node --test test/parser.test.js' - Windows doesn't expand glob patterns in the same way as Unix - Explicitly specify the test file to avoid cross-platform issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.