Skip to content

Commit 08e9876

Browse files
authored
Merge pull request #312 from jieyu/target_path
spec: Clarify target_path and staging_target_path
2 parents a033239 + 5efa594 commit 08e9876

File tree

3 files changed

+104
-92
lines changed

3 files changed

+104
-92
lines changed

csi.proto

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -939,10 +939,13 @@ message NodeStageVolumeRequest {
939939
// this capability. This is an OPTIONAL field.
940940
map<string, string> publish_info = 2;
941941

942-
// The path to which the volume will be published. It MUST be an
942+
// The path to which the volume MAY be staged. It MUST be an
943943
// absolute path in the root filesystem of the process serving this
944944
// request. The CO SHALL ensure that there is only one
945-
// staging_target_path per volume.
945+
// `staging_target_path` per volume. The CO SHALL ensure that the
946+
// process serving the request has `read` and `write` permission to
947+
// the path, and is able to create files or directories at the path
948+
// if it does not exist.
946949
// This is a REQUIRED field.
947950
string staging_target_path = 3;
948951

@@ -955,7 +958,7 @@ message NodeStageVolumeRequest {
955958
// section on how to use this field.
956959
map<string, string> secrets = 5 [(csi_secret) = true];
957960

958-
// Attributes of the volume to publish. This field is OPTIONAL and
961+
// Attributes of the volume to stage. This field is OPTIONAL and
959962
// MUST match the attributes of the `Volume` identified by
960963
// `volume_id`.
961964
map<string, string> volume_attributes = 6;
@@ -968,7 +971,7 @@ message NodeUnstageVolumeRequest {
968971
// The ID of the volume. This field is REQUIRED.
969972
string volume_id = 1;
970973

971-
// The path at which the volume was published. It MUST be an absolute
974+
// The path at which the volume was staged. It MUST be an absolute
972975
// path in the root filesystem of the process serving this request.
973976
// This is a REQUIRED field.
974977
string staging_target_path = 2;
@@ -988,7 +991,7 @@ message NodePublishVolumeRequest {
988991
// this capability. This is an OPTIONAL field.
989992
map<string, string> publish_info = 2;
990993

991-
// The path to which the device was mounted by `NodeStageVolume`.
994+
// The path to which the volume was staged by `NodeStageVolume`.
992995
// It MUST be an absolute path in the root filesystem of the process
993996
// serving this request.
994997
// It MUST be set if the Node Plugin implements the
@@ -999,8 +1002,9 @@ message NodePublishVolumeRequest {
9991002
// The path to which the volume will be published. It MUST be an
10001003
// absolute path in the root filesystem of the process serving this
10011004
// request. The CO SHALL ensure uniqueness of target_path per volume.
1002-
// The CO SHALL ensure that the path exists, and that the process
1003-
// serving the request has `read` and `write` permissions to the path.
1005+
// The CO SHALL ensure that the process serving the request has
1006+
// `read` and `write` permissions to the path, and is able to create
1007+
// files or directories at the path if it does not exist.
10041008
// This is a REQUIRED field.
10051009
string target_path = 4;
10061010

0 commit comments

Comments
 (0)