gha: Release a vendor tarball for distributions to do offline builds #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distributions need to be able to build offline using static sources. I didn't bother including the tarball in development releases to save space. The vendoring is done just before the actual build so that the build can reuse these files, avoiding the need to download them again for each platform. Signed-off-by: James Le Cuirot <[email protected]>
Contributor
Author
|
Thank you very much for merging. If you do encounter any issues with this at release time, please let me know. |
Contributor
Author
|
Hmm, was there a problem already? I can't see any actual error message though. 😕 |
Contributor
Author
|
Maybe not. This seems to happen when every PR is merged. |
Member
|
I think there is something different between actions/download-artifact@v6 and v4. |
Member
|
still fails...let me check..😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Distributions need to be able to build offline using static sources. I didn't bother including the tarball in development releases to save space.
The vendoring is done just before the actual build so that the build can reuse these files, avoiding the need to download them again for each platform.
I have tested this as much as I can locally using act.
Please check the following list: