-
Notifications
You must be signed in to change notification settings - Fork 12
Add Github actions to verify PRs #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds CI/CD infrastructure for the nerdbox project, including protobuf tooling installation scripts, linting workflows, and dependency management. The changes establish automated validation for code quality, go modules, and protobuf definitions.
- Adds installation scripts for protobuf compiler and related Go tools
- Implements GitHub Actions workflows for linting, project checks, and protobuf validation
- Updates Makefile with vendor verification target and improved path handling
- Promotes
github.com/vishvananda/netnsfrom indirect to direct dependency
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| script/install-protobuf | Adds script to download/install protobuf compiler and status.proto file |
| script/install-proto-tools | Adds script to install Go-based protobuf tooling via go install |
| .github/workflows/ci.yml | Creates CI workflow with linters, project checks, and protobuf validation jobs |
| .github/actions/install-go/action.yml | Defines reusable GitHub Action for Go installation |
| Makefile | Adds verify-vendor target and updates ROOTDIR and proto-fmt paths |
| go.mod | Moves vishvananda/netns from indirect to direct dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c30838c to
23a1be0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
849432c to
1844894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d5dac65 to
6909c02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3270f96 to
1427394
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1427394 to
a053509
Compare
a053509 to
99acc52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 22 out of 24 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
99acc52 to
f5bedce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 22 out of 32 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if len(a) == 0 { | ||
| return nil | ||
| } | ||
| o := make([]unsafe.Pointer, len(a)+1, len(a)+1) | ||
| o := make([]unsafe.Pointer, len(a)+1) |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Redundant capacity specification in make. The capacity parameter len(a)+1 is the same as the length, so it can be omitted: make([]unsafe.Pointer, len(a)+1).
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
6040d2c to
537748c
Compare
|
No more trailing whitespace |
Add initial GHA