Skip to content

Conversation

@dmcgowan
Copy link
Member

Add initial GHA

Copilot AI review requested due to automatic review settings October 31, 2025 19:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CI/CD infrastructure for the nerdbox project, including protobuf tooling installation scripts, linting workflows, and dependency management. The changes establish automated validation for code quality, go modules, and protobuf definitions.

  • Adds installation scripts for protobuf compiler and related Go tools
  • Implements GitHub Actions workflows for linting, project checks, and protobuf validation
  • Updates Makefile with vendor verification target and improved path handling
  • Promotes github.com/vishvananda/netns from indirect to direct dependency

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
script/install-protobuf Adds script to download/install protobuf compiler and status.proto file
script/install-proto-tools Adds script to install Go-based protobuf tooling via go install
.github/workflows/ci.yml Creates CI workflow with linters, project checks, and protobuf validation jobs
.github/actions/install-go/action.yml Defines reusable GitHub Action for Go installation
Makefile Adds verify-vendor target and updates ROOTDIR and proto-fmt paths
go.mod Moves vishvananda/netns from indirect to direct dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 19:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dmcgowan dmcgowan force-pushed the gha-verifications branch 2 times, most recently from 849432c to 1844894 Compare October 31, 2025 20:11
Copilot AI review requested due to automatic review settings October 31, 2025 20:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 20:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dmcgowan dmcgowan force-pushed the gha-verifications branch 2 times, most recently from 3270f96 to 1427394 Compare October 31, 2025 20:35
Copilot AI review requested due to automatic review settings October 31, 2025 20:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dmcgowan dmcgowan marked this pull request as ready for review October 31, 2025 20:41
Copilot AI review requested due to automatic review settings October 31, 2025 20:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 22 out of 24 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 21:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 22 out of 32 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

if len(a) == 0 {
return nil
}
o := make([]unsafe.Pointer, len(a)+1, len(a)+1)
o := make([]unsafe.Pointer, len(a)+1)
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Redundant capacity specification in make. The capacity parameter len(a)+1 is the same as the length, so it can be omitted: make([]unsafe.Pointer, len(a)+1).

Copilot uses AI. Check for mistakes.
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan
Copy link
Member Author

No more trailing whitespace

@dmcgowan dmcgowan merged commit 5d65a24 into containerd:main Oct 31, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant