-
Notifications
You must be signed in to change notification settings - Fork 12
Add linting to docker bake for local validation #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds linting capabilities to the Docker bake configuration for local validation. It introduces a comprehensive linting setup that includes golangci-lint, yamllint, and Dockerfile validation to improve code quality and consistency.
- Adds a new "validate" group to docker-bake.hcl with lint and validate-dockerfile targets
- Updates the CI workflow to use Docker-based linting instead of golangci-lint-action
- Introduces yamllint configuration for YAML file validation
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docker-bake.hcl | Adds validate group with lint and validate-dockerfile targets, including matrix builds for different linting tools |
| Makefile | Adds validate and lint targets that invoke Docker bake commands |
| Dockerfile | Implements multi-stage build for golangci-lint, yamllint, and related linting infrastructure |
| .yamllint.yml | Configuration file for yamllint with custom rules and exclusions |
| .github/workflows/ci.yml | Simplifies CI by replacing golangci-lint-action with Docker-based validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cf282dc to
8d54df5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
39dbe16 to
a0e010c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
A little opinionated but as a bonus I threw in YAML and Dockerfile validation. I'd like to get the protobuf validation and generation next because I am bad at install all the tools locally myself. 😅 |
|
Needs #37 for project checks |
|
Protobuf would be very useful for sure, we could use that in containerd as well since it is a bit of a pain. New approach looks good, just rebase and can get this one in next |
Signed-off-by: Austin Vazquez <[email protected]>
a0e010c to
ca1cfe8
Compare
Adds golangci-lint to the Docker bake for local validation.