Skip to content

Conversation

@austinvazquez
Copy link
Member

Adds golangci-lint to the Docker bake for local validation.

Copilot AI review requested due to automatic review settings November 1, 2025 00:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds linting capabilities to the Docker bake configuration for local validation. It introduces a comprehensive linting setup that includes golangci-lint, yamllint, and Dockerfile validation to improve code quality and consistency.

  • Adds a new "validate" group to docker-bake.hcl with lint and validate-dockerfile targets
  • Updates the CI workflow to use Docker-based linting instead of golangci-lint-action
  • Introduces yamllint configuration for YAML file validation

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docker-bake.hcl Adds validate group with lint and validate-dockerfile targets, including matrix builds for different linting tools
Makefile Adds validate and lint targets that invoke Docker bake commands
Dockerfile Implements multi-stage build for golangci-lint, yamllint, and related linting infrastructure
.yamllint.yml Configuration file for yamllint with custom rules and exclusions
.github/workflows/ci.yml Simplifies CI by replacing golangci-lint-action with Docker-based validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@austinvazquez austinvazquez force-pushed the add-local-linting branch 2 times, most recently from cf282dc to 8d54df5 Compare November 1, 2025 00:25
Copilot AI review requested due to automatic review settings November 1, 2025 00:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@austinvazquez austinvazquez force-pushed the add-local-linting branch 2 times, most recently from 39dbe16 to a0e010c Compare November 1, 2025 00:32
Copilot AI review requested due to automatic review settings November 1, 2025 00:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@austinvazquez
Copy link
Member Author

A little opinionated but as a bonus I threw in YAML and Dockerfile validation. I'd like to get the protobuf validation and generation next because I am bad at install all the tools locally myself. 😅

@austinvazquez austinvazquez self-assigned this Nov 1, 2025
@austinvazquez
Copy link
Member Author

Needs #37 for project checks

@dmcgowan
Copy link
Member

dmcgowan commented Nov 1, 2025

Protobuf would be very useful for sure, we could use that in containerd as well since it is a bit of a pain.

New approach looks good, just rebase and can get this one in next

@dmcgowan dmcgowan merged commit f4b3163 into containerd:main Nov 1, 2025
3 checks passed
@austinvazquez austinvazquez deleted the add-local-linting branch November 2, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants