image: support import command #4456
Merged
+665
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengyuZhu6
force-pushed
the
import
branch
6 times, most recently
from
2669717 to
05f9a13
Compare
|
In rootless without detach-netns (old rootlesskit), httptest server on 127.0.0.1 may be not reachable from the reexec'ed nerdctl process network namespace, causing connection refused: https://github.com/containerd/nerdctl/actions/runs/17028935400/job/48284540725?pr=4456 |
Signed-off-by: ChengyuZhu6 <[email protected]>
add unit tests for image import command Signed-off-by: ChengyuZhu6 <[email protected]>
Signed-off-by: ChengyuZhu6 <[email protected]>
I've add a helper to run a cross-namespace httpserver in image import unittest, let's see if the ci can be on green. |
Add helper to run a cross-namespace HTTP server. Signed-off-by: ChengyuZhu6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4457