Refactor image management to use transfer service #4583
+943
−370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengyuZhu6
force-pushed
the
transfer
branch
2 times, most recently
from
285c273 to
156a92a
Compare
AkihiroSuda
reviewed
Nov 5, 2025
cmd/nerdctl/image/image_import.go
Outdated
|
|
||
| cmd.Flags().StringP("message", "m", "", "Set commit message for imported image") | ||
| cmd.Flags().String("platform", "", "Set platform for imported image (e.g., linux/amd64)") | ||
| cmd.Flags().Bool("local", false, "Import content locally rather than using transfer service") |
Member
There was a problem hiding this comment.
For simplicity can we just remove the support for local mode?
Member
Author
There was a problem hiding this comment.
Ok, but this means that containerd versions <= 1.6 will be unsupported starting with the next release.
ChengyuZhu6
force-pushed
the
transfer
branch
19 times, most recently
from
7038aee to
0837936
Compare
Signed-off-by: ChengyuZhu6 <[email protected]>
Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
transfer
branch
2 times, most recently
from
b5584fe to
18b0448
Compare
ChengyuZhu6
force-pushed
the
transfer
branch
2 times, most recently
from
9df0074 to
40fab2d
Compare
Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
transfer
branch
from
40fab2d to
38ce692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4573