fix: return error for invalid --pull option in nerdctl compose create #4686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, specifying an invalid string for the --pull option of the nerdctl compose create command causes it to fall back to missing, allowing the image to be pulled as shown below. ``` $ sudo nerdctl compose create --pull foo WARN[0000] Ignoring: service svc0: pull_policy: "foo" INFO[0000] Ensuring image alpine ... INFO[0004] Creating container fix-compose-pull-policy-with-invalid-option-svc0-1 ``` On the other hand, docker compose returns the following error in a similar situation. ``` $ docker compose create --pull foo invalid --pull option "foo" ``` This commit fixes it to be compatible with docker compose. Signed-off-by: Hayato Kiwata <[email protected]>
Member
Author
|
Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, specifying an invalid string for the --pull option of the nerdctl compose create command causes it to fall back to missing, allowing the image to be pulled as shown below.
On the other hand, docker compose returns the following error in a similar situation.
This commit fixes it to be compatible with docker compose.